feat: Change gas for emit event as linear #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
linear-event-gas
branch
4 times, most recently
from
eb36df7 to
2de5240
Compare
howjmay
force-pushed
the
linear-event-gas
branch
24 times, most recently
from
9e10b71 to
65b78c0
Compare
howjmay
force-pushed
the
linear-event-gas
branch
from
65b78c0 to
8574530
Compare
howjmay
requested review from
jorgemmsilva,
BugFreeSoftware and
dessaya
and removed request for
jorgemmsilva
howjmay
commented
Aug 8, 2023
packages/vm/gas/table.go
Outdated
| @@ -66,7 +66,7 @@ var burnTable = BurnTable{ | |||
| BurnCodeUtilsBLSValidSignature: {"bls valid", constValue(2000)}, | |||
| BurnCodeUtilsBLSAddrFromPubKey: {"bls addr", constValue(50)}, | |||
| BurnCodeUtilsBLSAggregateBLS1P: {"bls aggregate", linear(CoefBLSAggregate)}, | |||
| BurnCodeMinimumGasPerRequest1P: {"minimum gas per request", minBurn(10000)}, // TODO maybe make it configurable (gov contract?) | |||
| BurnCodeMinimumGasPerRequest1P: {"minimum gas per request", minBurn(10000)}, // TODO maybe make it configurable (gov contract?) // FIXME not equal to wasmlib.MinGasFee | |||
There was a problem hiding this comment.
This value is not relative to wasmlib.MinGasFee. Should it relate to wasmlib.MinGasFee?
There was a problem hiding this comment.
I guess wasmlib needs to be updated to whatever value we set here
There was a problem hiding this comment.
It was not the same too. But as you said, I think it is better to synchronize them
howjmay
force-pushed
the
linear-event-gas
branch
2 times, most recently
from
5cb42fb to
aa1332a
Compare
dessaya
reviewed
Aug 9, 2023
packages/chain/cons/cons_test.go
Outdated
| @@ -346,7 +347,8 @@ func testChained(t *testing.T, n, f, b int) { | |||
| inccounter.FuncIncCounter.Hname(), | |||
| dict.New(), | |||
| uint64(i*reqPerBlock+ii), | |||
| 20000, | |||
| // FIXME may user other MinGasFee instead of wasmlib.MinGasFee | |||
| wasmlib.MinGasFee, | |||
There was a problem hiding this comment.
At the very least, wasp core packages like this should not depend on wasmlib.
howjmay
force-pushed
the
linear-event-gas
branch
8 times, most recently
from
139e2dc to
98fffe2
Compare
dessaya
approved these changes
Aug 10, 2023
| BurnCodeGetAllowance: {"allowance", constValue(10)}, | ||
| BurnCodeTransferAllowance: {"transfer", constValue(10)}, | ||
| BurnCodeEstimateStorageDepositCost: {"storage deposit estimate", constValue(5)}, | ||
| BurnCodeSendL1Request: {"send", linear(Coef1Send)}, | ||
| BurnCodeDeployContract: {"deploy", constValue(10)}, | ||
| BurnCodeStorage1P: {"storage", linear(1)}, // 1 gas per byte | ||
| BurnCodeStorage1P: {"storage", linear(55)}, // 55 gas per byte |
There was a problem hiding this comment.
Just curious, how did you arrive at this number?
There was a problem hiding this comment.
It is about the ratio of gas per byte of ETH storage and event
howjmay
force-pushed
the
linear-event-gas
branch
from
98fffe2 to
6706234
Compare
howjmay
force-pushed
the
linear-event-gas
branch
from
6706234 to
436a210
Compare
howjmay
force-pushed
the
linear-event-gas
branch
from
436a210 to
f7083b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2742