Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Enable workflow 'Build and run grpc tests' when grpc bindings receive more priority #1507

Open
chrisgitiota opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog

Comments

@chrisgitiota
Copy link

Description

Currently the workflow Build and run grpc tests is disabled because of build issues similar to the following console log:

671.7 error: implementation of std::marker::Send is not general enough
671.7 --> src/services/document.rs:70:3
671.7 |
671.7 70 | / #[tracing::instrument(
671.7 71 | | name = "create_did_document",
671.7 72 | | skip_all,
671.7 73 | | fields(request = ?req.get_ref())
671.7 74 | | ret,
671.7 75 | | err,
671.7 76 | | )]
671.7 | |____^ implementation of std::marker::Send is not general enough
671.7 |
671.7 = note: std::marker::Send would have to be implemented for the type &StrongholdStorage
671.7 = note: ...but std::marker::Send is actually implemented for the type &'0 StrongholdStorage, for some specific lifetime '0
671.7 = note: this error originates in the attribute macro tracing::instrument (in Nightly builds, run with -Z macro-backtrace for more info)

This is probably related to the rust compiler bug Tracking issue for incorrect lifetime bound errors in async. As long as our focus is on typescript bindings and wasm32 platforms we postpone resolving this issue.

After an alpha release including typescript bindings, we need to re-enable the 'Build and run grpc tests' and fix/circumvent the above described issue.

@chrisgitiota chrisgitiota added gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog labels Jan 22, 2025
@chrisgitiota chrisgitiota self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant