Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix allowance = output amount l1-l2 tx leads to funds stuck in layer 1.5 #7693

Closed
begonaalvarezd opened this issue Nov 7, 2023 · 0 comments · Fixed by #7696
Closed

[Task]: Fix allowance = output amount l1-l2 tx leads to funds stuck in layer 1.5 #7693

begonaalvarezd opened this issue Nov 7, 2023 · 0 comments · Fixed by #7696
Assignees
@begonaalvarezd
Labels
type:fix Fix for bug
Milestone
E00.M1 - Stardust...

Comments

@begonaalvarezd
Copy link
Member

Task description

We have a user with funds stuck in layer 1.5 because it seems like we either got a 0 gasFee or something, so allowance = output amount --> instant fail because there are no base tokens left to pay for the gas fee. We should never allow this case. Note that in that tx "gasBudget": 9007199254740990 provides a hint that probably the request to wasp to estimate the gas failed
@begonaalvarezd begonaalvarezd added the type:fix Fix for bug label Nov 7, 2023
@begonaalvarezd begonaalvarezd moved this from 📋 Backlog to 🔖 Todo in Firefly - Task Management Nov 7, 2023
@begonaalvarezd begonaalvarezd self-assigned this Nov 7, 2023
@begonaalvarezd begonaalvarezd mentioned this issue Nov 7, 2023
Merged
@begonaalvarezd begonaalvarezd moved this from 🔖 Todo to 👀 Needs Review in Firefly - Task Management Nov 7, 2023
@begonaalvarezd begonaalvarezd moved this from 👀 Needs Review to 📝 Changes Requested in Firefly - Task Management Nov 13, 2023
@begonaalvarezd begonaalvarezd moved this from 📝 Changes Requested to 👀 Needs Review in Firefly - Task Management Nov 13, 2023
@cpl121 cpl121 moved this from 👀 Needs Review to 📝 Changes Requested in Firefly - Task Management Nov 16, 2023
@cpl121 cpl121 moved this from 📝 Changes Requested to ✅ PR Approved in Firefly - Task Management Nov 20, 2023
@github-project-automation github-project-automation bot moved this from ✅ PR Approved to 🎉 Done in Firefly - Task Management Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@begonaalvarezd begonaalvarezd

Labels
type:fix Fix for bug
Projects
Firefly - Task Management
Status: 🎉 Done
Milestone
E00.M1 - Stardust Backlog
Development

Successfully merging a pull request may close this issue.

fix: do not allow sending if failed to request estimategas-onledger iotaledger/firefly
1 participant
@begonaalvarezd