Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed Return Types in Info Panel are incorrect #682

Closed
baronfel opened this issue Dec 17, 2020 · 2 comments
Closed

Displayed Return Types in Info Panel are incorrect #682

baronfel opened this issue Dec 17, 2020 · 2 comments
Labels

Comments

@baronfel
Copy link
Contributor

image (1)
image (2)

The problem is with the regexes that we use in the documentation formatter, they are too greedy.

A proper fix would be to not format the type signatures as postfix types (int list) instead of prefix types (list), but this doesn't currently exist in FCS. This PR adds such a facility, and when it's available we should make use of it.

@baronfel
Copy link
Contributor Author

The backing PR has been merged, and now we're just waiting on a version of FCS to be made available containing the fix.

@baronfel
Copy link
Contributor Author

baronfel commented May 8, 2021

We've updated FCS and incorporated the use of the new formatting flag so that we don't have to regex-replace the types anymore, so this can be closed.

@baronfel baronfel closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants