Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): add popover reserved keyword #6001

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Sukaato
Copy link
Contributor

@Sukaato Sukaato commented Sep 26, 2024

add popover keyword

fixes: #6000

What is the current behavior?

GitHub Issue Number: #6000

What is the new behavior?

Add popover has reserved keywork to avoid developer to name a property in a component with this name to do not have unexpected comportment outside stencil dev mode

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Manual testting

Other information

@Sukaato Sukaato requested a review from a team as a code owner September 26, 2024 20:35
@Sukaato Sukaato force-pushed the fix/add-reserved-keyword branch from dffb152 to c50cc59 Compare September 26, 2024 20:36
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tanner-reits tanner-reits changed the title fix(compiler): add reserved keyword fix(compiler): add popover reserved keyword Sep 27, 2024
@tanner-reits tanner-reits added this pull request to the merge queue Sep 27, 2024
Merged via the queue into ionic-team:main with commit 7ede77a Sep 27, 2024
88 checks passed
@Sukaato Sukaato deleted the fix/add-reserved-keyword branch September 27, 2024 08:39
@christian-bromann
Copy link
Member

Released in Stencil v4.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Add missing HTML reserved keyword
3 participants