Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(declarations): add popover attributes to JSX declarations #5064

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat(declarations): add popover attributes to JSX declarations #5064

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ece649
feat(declarations): add popover attributes
tanner-reits Nov 13, 2023
68c7696
align types with lib.dom.ts types
tanner-reits Nov 15, 2023
c2a9dc6
add comment
tanner-reits Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/declarations/stencil-public-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,11 @@ export namespace JSXBase {
name?: string;
type?: string;
value?: string | string[] | number;

// popover
popoverTargetAction?: string;
popoverTargetElement?: Element | null;
popoverTarget?: string;
}

export interface CanvasHTMLAttributes<T> extends HTMLAttributes<T> {
Expand Down Expand Up @@ -1074,6 +1079,11 @@ export namespace JSXBase {
webkitdirectory?: boolean;
webkitEntries?: any;
width?: number | string;

// popover
popoverTargetAction?: string;
popoverTargetElement?: Element | null;
popoverTarget?: string;
}

export interface KeygenHTMLAttributes<T> extends HTMLAttributes<T> {
Expand Down Expand Up @@ -1364,6 +1374,11 @@ export namespace JSXBase {
tabIndex?: number;
tabindex?: number | string;
title?: string;
// These types don't allow you to use popover as a boolean attribute
// so you can't write HTML like `<div popover>` and get the default value.
// Developer must explicitly specify one of the valid popover values or it will fallback
// to `manual` (following the HTML spec).
popover?: string | null;

// Unknown
inputMode?: string;
Expand Down
Loading