Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Dynamically rendered slot elements causes NotFoundError on insertBefore call #6140

Closed
3 tasks done
itsjustaplant opened this issue Feb 4, 2025 · 1 comment
Closed
3 tasks done
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil Help Wanted

Comments

@itsjustaplant
Copy link
Contributor

itsjustaplant commented Feb 4, 2025

Prerequisites

Stencil Version

4.25.1

Current Behavior

Dynamically rendered slot elements causes issue while patched insertBefore function tries to insert the child.

Image

This happens because currentChild element is encapsulated by another element therefore it's parent element is not same with the patched node.

Expected Behavior

It should insert elements without an error.

System Info

System: node 23.4.0
    Platform: windows (10.0.26100)
       Build: 1737767058
     Stencil: 4.25.1
  TypeScript: 5.5.4
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.31.1

Steps to Reproduce

reproduction url: https://github.com/itsjustaplant/stencil-mono/tree/issue/insertBefore

Code Reproduction URL

https://github.com/itsjustaplant/stencil-mono/tree/issue/insertBefore

Additional Information

No response

@christian-bromann
Copy link
Member

A patch for this has been released in v4.27.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil Help Wanted
Projects
None yet
Development

No branches or pull requests

2 participants