Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mock-doc): assignednodes and assignedElements #6108

Merged

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Jan 21, 2025

What is the current behavior?

GitHub Issue Number: #2830

Within mock-doc (i.e SSR hydration and spec tests) the native assignednodes and assignedElements methods for a <slot /> are not available.

What is the new behavior?

A new MockSlotElement has been added to the mock-doc element.ts with the new methods.

Fixes: #2830

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • New spec tests for the <slot /> methods have been added

Other information

@johnjenkins johnjenkins requested a review from a team as a code owner January 21, 2025 00:44
@johnjenkins johnjenkins changed the title Feat mock doc assignednodes feat(mock-doc) assignednodes and assignedElements Jan 21, 2025
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌

@johnjenkins johnjenkins changed the title feat(mock-doc) assignednodes and assignedElements feat(mock-doc): assignednodes and assignedElements Jan 21, 2025
@johnjenkins
Copy link
Contributor Author

@christian-bromann the flaky wdio test is made more reliable in this PR < shall I copy it over to here, or just wait for that one to be merged?

@christian-bromann christian-bromann merged commit 777aafd into stenciljs:main Jan 21, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLSlotElement assignedElements / assignedNodes not available in spec tests (reopen)
2 participants