fix(runtime): revert slot relocation forwarding #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/mock-doc/serialize-node.ts | 36 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/testing/puppeteer/puppeteer-element.ts | 22 |
| src/runtime/client-hydrate.ts | 20 |
| src/screenshot/connector-base.ts | 19 |
| src/runtime/vdom/vdom-render.ts | 18 |
| src/compiler/config/test/validate-paths.spec.ts | 16 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/compiler/transpile/transpile-module.ts | 14 |
| src/runtime/vdom/vdom-annotations.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/prerender/prerender-queue.ts | 13 |
| src/compiler/sys/in-memory-fs.ts | 13 |
| src/runtime/connected-callback.ts | 13 |
| src/runtime/set-value.ts | 13 |
| src/compiler/output-targets/output-www.ts | 12 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2345 | 369 |
| TS2322 | 366 |
| TS18048 | 237 |
| TS18047 | 103 |
| TS2722 | 37 |
| TS2532 | 26 |
| TS2531 | 23 |
| TS2454 | 14 |
| TS2352 | 12 |
| TS2790 | 11 |
| TS2769 | 8 |
| TS2538 | 8 |
| TS2344 | 6 |
| TS2416 | 6 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2430 | 1 |
Unused exports report
There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/utils/index.ts | 269 | normalize |
| src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 115 | Env |
| src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
alicewriteswrongs
approved these changes
Jan 5, 2024
christian-bromann
approved these changes
Jan 5, 2024
|
maybe a unit test like in this commit? cheers and thanks for your effort |
rwaskiewicz
reviewed
Jan 8, 2024
| if (childNode.nodeType === NODE_TYPE.ElementNode && !!childNode['s-sn']) { | ||
| childNode.setAttribute('slot', childNode['s-sn']); | ||
| } | ||
|
|
||
| // Need to tell the render pipeline to check to relocate slot content again | ||
| checkSlotRelocate = true; | ||
| } |
There was a problem hiding this comment.
I can't comment on the line itself, but do we still need this if statement, also introduced in #4993?
There was a problem hiding this comment.
Yep that can go too. Good call. Merged into commit d2ab331
This commit reverts some logic in the runtime attempting to handle the use case of slots being slotted into other slots where the slot name changes along the way. The Stencil runtime cannot handle this use case elegantly because it relocates the node in the DOM rather than having references to nodes like the native Shadow DOM. For this use case, it is recommended to either use shadow encapsulation for all components involved, or to keep the slot name consistent through the component tree. Reverts 21b3bf0, 9adcfab, and part of 0106e0b Fixes #5215
tanner-reits
force-pushed
the
treits/fix/slot-regressions/revert-slot-name-forwarding
branch
from
7dac2c6 to
d2ab331
Compare
rwaskiewicz
approved these changes
Jan 8, 2024
tanner-reits
deleted the
treits/fix/slot-regressions/revert-slot-name-forwarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Changes made in #4940 and #4993 are causing issues in the Ionic Framework screenshot testing with
experimentalSlotFixesenabled. With this behavior, theslotattribute can get removed from elements which is an issue if styles target the attribute (i.e. something like::slotted([slot="start"])).Fixes #5215
What is the new behavior?
This commit reverts some logic in the runtime attempting to handle the use case of slots being slotted into other slots where the slot name changes along the way. The Stencil runtime cannot handle this use case elegantly because it relocates the node in the DOM rather than having references to nodes like the native Shadow DOM.
For this use case, it is recommended to either use shadow encapsulation for all components involved, or to keep the slot name consistent through the component tree.
Reverts 21b3bf0, 9adcfab, and part of 0106e0b
Does this introduce a breaking change?
Not a breaking change since this behavior was being the
experimentalSlotFixesflag anywayTesting
Automated tests are passing and Framework screenshot tests are passing as can be seen in this run of the nightly workflow
Other information
Stencil is not setup to handle this use case with the current slot polyfill logic. This limitation is called out in the Stencil docs: ionic-team/stencil-site#1306