Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: popover is not a known attribute of [element] #4745

Closed
3 tasks done
gfellerph opened this issue Aug 31, 2023 · 2 comments · Fixed by #5064
Closed
3 tasks done

bug: popover is not a known attribute of [element] #4745

gfellerph opened this issue Aug 31, 2023 · 2 comments · Fixed by #5064
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@gfellerph
Copy link

Prerequisites

Stencil Version

3.4.2

Current Behavior

When adding an element with the popover attribute <div popover></div>, there is a typescript error on the console.

Type '{ popover: true; }' is not assignable to type
'HTMLAttributes<HTMLDivElement>'.Property 'popover' does not exist
on type 'HTMLAttributes<HTMLDivElement>'.
     <Host data-version={version}>
       <div popover></div>
       <div class="tabs-wrapper">
rebuild failed, watching for changes... in 106 ms

Expected Behavior

The standard popover attribute is a known attribute.

System Info

System: node 16.20.0
    Platform: darwin (22.5.0)
   CPU Model: Apple M1 Pro (8 cpus)
    Compiler: /Users/.../design-system/node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/compiler/stencil.js
       Build: 1690208000
     Stencil: 3.4.2 ☀️
  TypeScript: 5.0.4
      Rollup: 2.42.3
      Parse5: 7.1.2
      Sizzle: 2.42.3
      Terser: 5.18.1

Steps to Reproduce

Write a component that uses popover on any element.

Code Reproduction URL

https://github.com/gfellerph/stencil-popover-repro

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Aug 31, 2023
@rwaskiewicz rwaskiewicz self-assigned this Sep 6, 2023
@rwaskiewicz
Copy link
Contributor

Thanks @gfellerph! I've confirmed that this is an issue in the typings - we'll keep an eye on popover (which is still marked as experimental/in technical preview in Firefox and Safari) and add it accordingly. Thanks again!

@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label Sep 6, 2023
@rwaskiewicz rwaskiewicz removed their assignment Sep 6, 2023
@ionitron-bot ionitron-bot bot removed the triage label Sep 6, 2023
@alicewriteswrongs
Copy link
Contributor

The fix for this issue has been released as a part of today's Stencil v4.8.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants