Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock-doc): add missing methods to the element mock #3480

Merged

Conversation

erwinheitzman
Copy link
Contributor

NOTE: I have previously created issues and example repositories but since this is a really small PR that does not impact any users directly, I feel that this can be done without an accompanied issue. If you feel differently about this, do say so.

Add missing methods to the mock-doc MockElement class.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The methods that have been added were missing, causing errors.

GitHub Issue Number: N/A

What is the new behavior?

No error is thrown when your component uses any of the methods while running unit tests.

Does this introduce a breaking change?

  • Yes
  • No

@erwinheitzman erwinheitzman requested a review from a team July 20, 2022 09:10
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rwaskiewicz
Copy link
Contributor

For historical purposes: I'm going to merge this as an admin. The "Tech Debt Burndown / Download error files and report (pull_request)" currently fails on PRs that come from forks. It generates the report just fine (which for this PR, states we are not introducing any unused functions / strictNullChecks violations), but can't add the comment to the PR with the report's contents. We'll fix this next sprint, but I don't see that as a reason to block the PR in the meantime

@rwaskiewicz rwaskiewicz merged commit 835e00f into ionic-team:main Jul 20, 2022
@rwaskiewicz rwaskiewicz added the Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. label Jul 20, 2022
@rwaskiewicz
Copy link
Contributor

The fix for this issue has been officially released as a part of Stencil v2.17.2.

@erwinheitzman erwinheitzman deleted the add-missing-element-mock-methods branch August 5, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants