-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for escaped ':' in CSS selectors #3087
Account for escaped ':' in CSS selectors #3087
Conversation
👋 Hey there! Thanks for the PR! I've updated it with the 'Resolution: Refine' label to get this added to one of our sprints to be fully looked at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Thanks! I have one main ask surrounding browser support for folks using our compiler API in browser. LMK if you have any questions!
I replaced the regex with something uglier but that should work in IE and Safari. 🙂 Also, a minor refactor to reuse the regex matching code (since matching groups can now be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run test.karma.prod
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #3083
What is the new behavior?
\:
remains escaped in CSS selectors when introducing scope classDoes this introduce a breaking change?
Testing
New unit tests added; tested it fixes reproduced issue #3083