Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for escaped ':' in CSS selectors #3087

Merged

Conversation

nemzes
Copy link
Contributor

@nemzes nemzes commented Sep 30, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #3083

What is the new behavior?

  • \: remains escaped in CSS selectors when introducing scope class

Does this introduce a breaking change?

  • Yes
  • No

Testing

New unit tests added; tested it fixes reproduced issue #3083

@nemzes nemzes requested a review from a team September 30, 2021 12:18
@rwaskiewicz rwaskiewicz added the Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. label Oct 4, 2021
@rwaskiewicz
Copy link
Contributor

👋 Hey there! Thanks for the PR! I've updated it with the 'Resolution: Refine' label to get this added to one of our sprints to be fully looked at.

Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks! I have one main ask surrounding browser support for folks using our compiler API in browser. LMK if you have any questions!

src/utils/shadow-css.ts Outdated Show resolved Hide resolved
@rwaskiewicz rwaskiewicz added the Awaiting Reply This PR or Issue needs a reply from the original reporter. label Oct 26, 2021
@nemzes
Copy link
Contributor Author

nemzes commented Oct 27, 2021

I replaced the regex with something uglier but that should work in IE and Safari. 🙂 Also, a minor refactor to reuse the regex matching code (since matching groups can now be undefined, they need defaults of ''

@ionitron-bot ionitron-bot bot added Reply Received and removed Awaiting Reply This PR or Issue needs a reply from the original reporter. labels Oct 27, 2021
@nemzes nemzes requested a review from rwaskiewicz November 3, 2021 23:13
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwaskiewicz rwaskiewicz merged commit 6000681 into ionic-team:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants