fix(events): map onFocusIn/Out to correct events #2745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2628.
Support for
onFocusIn
andonFocusOut
were added in #2437. These events are supported by all browsers and are widely used, but they're not defined as properties in the spec yet. As such, they don't exist as properties on thewindow
object.The end result is the attached listeners being
focusIn
andfocusOut
instead offocusin
andfocusout
.This PR adds an array of event transformations to fall back on for edge case events such as these.Update: we've decided to change the types to
onFocusin
andonFocusout
so we don't modify the runtime. Implemented in 513c571.