Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats output target not producing anything #2633

Closed
splitinfinities opened this issue Aug 13, 2020 · 2 comments
Closed

Stats output target not producing anything #2633

splitinfinities opened this issue Aug 13, 2020 · 2 comments

Comments

@splitinfinities
Copy link
Contributor

Stencil version:
After the next compiler was added: everything after @stencil/[email protected]
Tested this with:
@stencil/core v1.9.2 (Works)
@stencil/core v1.10.3 (Not Produced)
@stencil/core v1.10.3 (Not Produced)
@stencil/core v1.11.3 (Not Produced)
@stencil/core v1.12.7 (Not Produced)
@stencil/core v1.13.0 (Not Produced)
@stencil/core v1.14.0 (Not Produced)
@stencil/core v1.15.0 (Not Produced)
@stencil/core v1.16.5 (Not Produced)
@stencil/core v1.17.3 (Not Produced)

I'm submitting a:
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
When using either the --stats flag in a build, or the entry in outputTargets - { type: 'stats' } - a json file would be produced when doing npm run build

Expected behavior:
Well, a few options:

  1. it's been removed for the past 5 months, and I'm not sure how many people use it... remove the code that implies it exists. But that makes it so that we cannot do performance tweaks with other languages.

  2. Rebuild this, and improve support since mode's styles are also split out now too, potentially.

It would really help server side apps using any given design system - this is the lighthouse topic it intends to solve https://web.dev/uses-rel-preload

I used it in a couple rails apps during Stencil 1.7 but I haven't maintained that app in a while, even though it's still chugging along. Knowing that upgrading would nix that performance gain blocks me. I'd also like to open source whatever solution this file would provide in PHP - WordPress - and Ruby on Rails, if we can get it back.

Steps to reproduce:
Build any app or design system after v1.9.2 with the --stats flag or with { type: 'stats' } in the stencil config.

Related code:

// insert any relevant code here

Other information:

@ionitron-bot ionitron-bot bot added the triage label Aug 13, 2020
@splitinfinities
Copy link
Contributor Author

#3030 will resolve this

@rwaskiewicz
Copy link
Contributor

I’m going to close this issue, as #3030 has landed in the main branch and is a part of the v2.9.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants