Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polyfill): use core-js promise and iife fetch polyfill #2443

Merged

Conversation

warapitiya
Copy link
Contributor

Current polyfills are UMD supported. When appending Stencil.js to require.js web apps. IE breaks with an error Promise is undefined. This is due to es6-promise's UMD supported check.

typeof define === 'function' && define.amd ? define(factory) :

When I do a quick scan I found out that currently fetch polyfill also does a UMD check.

This PR will replace those 2 polyfills with below:

  • Remove es6-promise polyfill and replace it with core-js/es/promise.
  • Use fetch polyfill's IIFE version.

Issue related: #2418

@warapitiya warapitiya changed the title fix(polyfill): use core-js promise and iife fetch polyfill #2442 fix(polyfill): use core-js promise and iife fetch polyfill Jun 21, 2020
@adamdbradley adamdbradley merged commit 7b7ed0b into stenciljs:master Jul 22, 2020
@adamdbradley
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants