fixup! feat(compiler): copy dock block from component to generated types

ionic-team · Dec 1, 2022 · f0b2d37 · f0b2d37
1 parent 04d7731
commit f0b2d37
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/compiler/types/generate-app-types.ts b/src/compiler/types/generate-app-types.ts
@@ -133,7 +133,12 @@ const generateComponentTypesFile = (config: d.Config, buildCtx: d.BuildCtx, areT
   c.push(`}`);
 
   c.push(`declare namespace LocalJSX {`);
-  c.push(...modules.map((m) => `  ${m.jsx}`));
+  c.push(
+    ...modules.map((m) => {
+      const docs = components.find((c) => c.tagName === m.tagName).docs;
+      return addDocBlock(`  ${m.jsx}`, docs, 4);
+    })
+  );
 
   c.push(`        interface IntrinsicElements {`);
   c.push(...modules.map((m) => `              "${m.tagName}": ${m.tagNameAsPascal};`));

diff --git a/src/compiler/types/generate-component-types.ts b/src/compiler/types/generate-component-types.ts
@@ -51,7 +51,7 @@ export const generateComponentTypes = (
     tagNameAsPascal,
     htmlElementName,
     component: addDocBlock(`        interface ${tagNameAsPascal} {\n${componentAttributes}        }`, cmp.docs, 4),
-    jsx: addDocBlock(`    interface ${tagNameAsPascal} {\n${jsxAttributes}        }`, cmp.docs, 2),
+    jsx: `    interface ${tagNameAsPascal} {\n${jsxAttributes}        }`,
     element: element.join(`\n`),
   };
 };

diff --git a/test/karma/test-app/components.d.ts b/test/karma/test-app/components.d.ts
@@ -1497,10 +1497,9 @@ declare namespace LocalJSX {
     interface ShadowDomBasicRoot {
     }
     /**
-   * 
-   * @virtualProp {string} colormode - The mode determines which platform styles to use.
-   */
-  interface ShadowDomMode {
+     * @virtualProp {string} colormode - The mode determines which platform styles to use.
+     */
+    interface ShadowDomMode {
         /**
           * The mode determines which platform styles to use.
          */