Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-list has mysterious 32px margin-bottom on iOS #7366

Closed
martinjbaker opened this issue Jul 19, 2016 · 11 comments
Closed

ion-list has mysterious 32px margin-bottom on iOS #7366

martinjbaker opened this issue Jul 19, 2016 · 11 comments
Assignees
Labels
ionitron: v3 moves the issue to the ionic-v3 repository

Comments

@martinjbaker
Copy link

For some reason there's a 32px margin-bottom applied on ion-list which causes an unnecessary gap after the last item.

Best seen by scrolling the list to the bottom on the demo page:
http://ionicframework.com/docs/v2/components/#lists

Ionic 2 beta 10

@jgw96
Copy link
Contributor

jgw96 commented Jul 19, 2016

Hello, thanks for opening an issue with us! This is actually by design as this is how the lists look on the native platforms. You can read more about it here. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jul 19, 2016
@biesbjerg
Copy link

Can you provide more info? I've been wondering about the gap too. I don't see a gap in lists on iPhone's native phone app, App Store etc?

@martinjbaker
Copy link
Author

Sorry but at least on iOS that isn't the case. I made an example project in Xcode with a UITableView and there's no gap within the bounds of the tableview when it is scrolled to the bottom. The last item is aligned to the bottom of the tableview. See screenshot and attached project.

uitableview
SimpleTableView.zip

@martinjbaker
Copy link
Author

Also worth mentioning that this problem is new in Ionic 2. I'm converting an Ionic 1 app at the moment and previously didn't have to set margin-bottom to 0 on ion-list.

@mpaland
Copy link

mpaland commented Jul 20, 2016

I'm facing the same issue due to

ion-list {
  margin: -1px 0 32px 0;
}

in .ios.css
I know this margin should be a fix but isn't there a smarter solution? This big gap is really unwanted if other elements are below the list.

@jgw96 might you reopen this issue?

@jgw96 jgw96 reopened this Jul 20, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jul 20, 2016

Thanks for responding everyone! I have reopened this issue and will be discussing this with our design people.

@pietro909
Copy link

Hi, are there any updates? At least a suggestion about the best practice of how to fix it at a global level for the three different platforms.

Thanks

@MessiasLima
Copy link

Set this variables in variables.scss

$list-ios-margin-bottom : 0px;
$list-md-margin-bottom : 0px;

@adamdbradley adamdbradley added the ionitron: v3 moves the issue to the ionic-v3 repository label Nov 1, 2018
@imhoffd imhoffd added ionitron: v3 moves the issue to the ionic-v3 repository and removed ionitron: v3 moves the issue to the ionic-v3 repository labels Nov 1, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 1, 2018

Thanks for the issue! We have moved the source code and issues for Ionic 3 into a separate repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there.

Thank you for using Ionic!

@imhoffd imhoffd removed the ionitron: v3 moves the issue to the ionic-v3 repository label Nov 28, 2018
@Ionitron Ionitron added the ionitron: v3 moves the issue to the ionic-v3 repository label Nov 28, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 28, 2018

This issue has been automatically identified as an Ionic 3 issue. We recently moved Ionic 3 to its own repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there.

If I've made a mistake, and if this issue is still relevant to Ionic 4, please let the Ionic Framework team know!

Thank you for using Ionic!

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 28, 2018

Issue moved to: ionic-team/ionic-v3#120

@ionitron-bot ionitron-bot bot closed this as completed Nov 28, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ionitron: v3 moves the issue to the ionic-v3 repository
Projects
None yet
Development

No branches or pull requests

10 participants