Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add dir attribute for different language directions #13043

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Oct 4, 2017

Short description of what this resolves:

When having any input, no matter the direction of the app, writing ltr should be on the left, writing rtl should be on the right.

This is the behavior of most inputs across the web

Changes proposed in this pull request:

  • add dir="auto" to all of the inputs across the system

Ionic Version: 3.x

@manucorporat manucorporat merged commit b180351 into ionic-team:master Oct 6, 2017
@AmitMY
Copy link
Contributor Author

AmitMY commented Oct 6, 2017

Thanks @manucorporat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants