fix(swiper): add safe-guards when user tries to zoom a slide without … #12931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensodemann
force-pushed
the
fix/swiperZoom
branch
from
261b594 to
214fbdd
Compare
kensodemann
force-pushed
the
fix/swiperZoom
branch
from
214fbdd to
620f977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12861
Short description of what this resolves:
OP found this issue by forgetting to put image in slides with zoom="true", but in resolving this, I discovered that you would have the same issue if you had some slides with zoomable image and some slides without and the user accidentally did a zoom gesture on the slides without.
Changes proposed in this pull request:
Ionic Version: 3.x (not sure if we would need to fix (or how) in 4.x as we are changing this a lot)
Fixes: #12861