fix(navigation): handle null reference #12641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
reviewed
Aug 11, 2017
src/components/tabs/tabs.ts
Outdated
| @@ -643,6 +643,8 @@ export class Tabs extends Ion implements AfterViewInit, RootNode, ITabs, Navigat | |||
| * @private | |||
| */ | |||
| _getSelectedTabIndex(secondaryId: string, fallbackIndex: number = 0): number { | |||
| secondaryId = secondaryId || ''; | |||
There was a problem hiding this comment.
Any reason you didn't use default value for parameter? Like secondaryId: string = '', fallbackIndex: number = 0
|
@danbucholtz can you review this PR and merge it for the next release? |
|
Thanks for the PR! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure secondary ID is set