Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): remove margin of MD buttons in ion-item-options #12263

Merged
merged 1 commit into from
Jul 21, 2017
Merged

fix(list): remove margin of MD buttons in ion-item-options #12263

merged 1 commit into from
Jul 21, 2017

Conversation

pwespi
Copy link
Contributor

@pwespi pwespi commented Jul 5, 2017

Short description of what this resolves:

Remove margin of MD buttons in ion-item-options to make it the same as iOS. I haven't found anything in the material guidelines that justifies this margin.

Changes proposed in this pull request:

(click image to enlarge)
item-slide

Ionic Version: 2.x / 3.x

Copy link
Contributor

@manucorporat manucorporat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandyscarney tested locally and LGTM!

@brandyscarney brandyscarney merged commit 97f9522 into ionic-team:master Jul 21, 2017
@brandyscarney
Copy link
Member

Thanks for the PR! 🎉

@pwespi pwespi deleted the item-sliding-patch branch July 22, 2017 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants