-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL inputs and labels in IOS not stable during animations. #11745
Comments
Assigning our resident RTL expert @AmitMY 😃 |
@Khalid-Nowaf I think you were correct linking the issue to transform (#11649) as it seems like it causes at least some of it. Fortunately, some RTL fixes are already merged for Wednesday's scheduled release, and may fix some of the issues but not all of them. Thanks for reporting! I'll keep you updated when I look into it |
@Khalid-Nowaf As I don't have a mac, and can't emulate iOS, I was looking into your code to see what went wrong. Two things:
Sorry I can't offer anything better at the moment, I'll try to get a mac working to test this. |
Thanks @AmitMY, I will try the next realse to verify what get fixed, and form there probably we will have a smaller list of issues, and with your help I will try my best to fix them and I make some PR. I have a quick question, I fork ionic repo and wondering is there a way to run e2e test in cordova device? Not in the browser? So I can test my changes in real device or emulator. |
@Khalid-Nowaf Not an easy one. |
@AmitMY thanks! |
@AmitMY,@jgw96, I have tested the last ionic release, and the same issues appeared. I did some testing to answer the following:
and I can conclude the problem exist only in IOS device for both IOS and Material Design mode. This issues possibly caused by
some issue related: Here some videos |
@Khalid-Nowaf Are you using UI or WK on iOS? Installation instructions in case you are using UI and want to try it on WK - https://github.com/driftyco/cordova-plugin-wkwebview-engine#installation-instructions |
@AmitMY, I have test both, same issues. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Ionic version:
[ ] 1.x
[ ] 2.x
[X] 3.x
I'm submitting a ...
[X] bug report
[ ] feature request
[ ] support request
Current behavior:
Inputs and labels components for "IOS only" in "RTL" not stable when the app animate "during scrolling, input focusing. here are the issues
Here is a video showing the Current behavior --> (https://vimeo.com/218399024)
NOTE: this issues will appear only in IOS Device or emulator.
Expected behavior:
the input and labels should be stable in "RTL" as they stable in "LTR"
Steps to reproduce:
I have created a repo branch for this issue --> (https://github.com/Khalid-Nowaf/ionic-rtl/tree/unsmooth-animations)
Related code:
clone the repo, then
The text was updated successfully, but these errors were encountered: