Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

View not being updating properly when navigating to page after custom Promise shim gets resolved #382

Open
ionitron-bot bot opened this issue Nov 29, 2018 · 0 comments
Labels

Comments

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 29, 2018

Original issue by @aszmyd on 2018-06-28T09:13:02Z

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.

cli packages: (/home/aszmyd/.nvm/versions/node/v8.9.3/lib/node_modules)

    @ionic/cli-utils  : 1.19.0
    ionic (Ionic CLI) : 3.19.0

local packages:

    @ionic/app-scripts : 3.1.10
    Ionic Framework    : ionic-angular 3.9.2

System:

    Node : v8.9.3
    npm  : 5.5.1 
    OS   : Linux 4.13

Misc:

    backend : legacy

Describe the Bug
Calling navigation setRoot from within resolved custom shimmed Promise, two way data binding is broken on destination page.

When using custom Promise implementation (i used es6-promise), navigating to other page after such promise gets resolved makes two way binding broken.

No errors in console is visible, navigation is actually being made (you get redirected to page) and some bindings works on the page but it looks like the view is not being rendered properly.

Whats interesting is that such case works when you use available Promise implementation (not shim) which seems to be overriden by angular (ZoneAwarePromise).

Steps to Reproduce
Steps to reproduce the behavior:

  1. Create at least two page components
  2. Install some custom shimmed Promise library (i used es6-promise)
  3. Go to created page using setRoot after Promise gets resolved
  4. See that two way data binding is just not working

Related Code
I've created basic example of this: https://github.com/aszmyd/ionic-navigation-promise-binding-issue

Expected Behavior
Binding should always works.

Additional Context
I've captured small video of how its broken: https://github.com/aszmyd/ionic-navigation-promise-binding-issue/raw/master/video.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

0 participants