Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): better detect ssr envs #197

Merged
merged 1 commit into from
Sep 2, 2020
Merged

fix(storage): better detect ssr envs #197

merged 1 commit into from
Sep 2, 2020

Conversation

mhartington
Copy link
Contributor

Change the way that ssr/node envs are detected

Change the way that ssr/node envs are detected
@mhartington mhartington merged commit 5d69ad3 into main Sep 2, 2020
github-actions bot pushed a commit that referenced this pull request Sep 2, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
github-actions bot pushed a commit that referenced this pull request Sep 2, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
github-actions bot pushed a commit that referenced this pull request Sep 2, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
github-actions bot pushed a commit that referenced this pull request Sep 2, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
mhartington pushed a commit that referenced this pull request Sep 2, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
github-actions bot pushed a commit that referenced this pull request Sep 3, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-03)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
github-actions bot pushed a commit that referenced this pull request Sep 3, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-09-03)

### Bug Fixes

* **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
@github-actions
Copy link

github-actions bot commented Sep 3, 2020

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pookdeveloper
Copy link

@mhartington what is the new parameter "platformId" ?
Before I used like this now that I have to pass in the new parameter ? Thanks
this._storage = new Storage({
name: this.NAME,
storeName: this.TABLE_NAME,
driverOrder: tihs.DRIVERS
});

@mhartington
Copy link
Contributor Author

Since this is an angular module, you would use Angular's ngModules to include Ionic Storage.

https://github.com/ionic-team/ionic-storage#usage

Your way is not supported.

@pookdeveloper
Copy link

pookdeveloper commented Sep 8, 2020

I want to create dynamic storage with diferent drivers, so i call IonicStorageModule without .forroot and i create the instance in my service, so I cant do that ? Thanks @mhartington

@mhartington
Copy link
Contributor Author

That defeats the point of this package. If you want that, then just use localforage directly.

If there is any real issue, please open a new issue instead of commenting on PRs.

@ionic-team ionic-team locked and limited conversation to collaborators Sep 8, 2020
@mlynch mlynch deleted the fix-ssr-errors branch March 31, 2021 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants