-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): better detect ssr envs #197
Conversation
Change the way that ssr/node envs are detected
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-02) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-03) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
## [2.3.1](v2.3.0...v2.3.1) (2020-09-03) ### Bug Fixes * **storage:** better detect ssr envs ([#197](#197)) ([5d69ad3](5d69ad3))
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@mhartington what is the new parameter "platformId" ? |
Since this is an angular module, you would use Angular's ngModules to include Ionic Storage. https://github.com/ionic-team/ionic-storage#usage Your way is not supported. |
I want to create dynamic storage with diferent drivers, so i call IonicStorageModule without .forroot and i create the instance in my service, so I cant do that ? Thanks @mhartington |
That defeats the point of this package. If you want that, then just use localforage directly. If there is any real issue, please open a new issue instead of commenting on PRs. |
Change the way that ssr/node envs are detected