Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onesignal): Improving OneSignal definitions #888

Merged
merged 5 commits into from
Dec 27, 2016

Conversation

dudeofawesome
Copy link
Contributor

No description provided.

@ihadeed
Copy link
Collaborator

ihadeed commented Dec 18, 2016

It would be nice to prefix all the interfaces/enums with OS or OneSignal just to make sure that it doesn't conflict with anything in the future.

@ihadeed ihadeed merged commit 56e8eae into danielsogl:master Dec 27, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Dec 27, 2016

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants