Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): update Network plugin #3608

Merged
merged 1 commit into from
Apr 5, 2021
Merged

feat(network): update Network plugin #3608

merged 1 commit into from
Apr 5, 2021

Conversation

timkovik
Copy link
Contributor

Extends onChange Observable with types of connection to which it changed

@timkovik
Update Network plugin
dff0067 
Extends onChange Observable with types of connection to which it changed
@timkovik
Copy link
Contributor Author

@ihadeed @don plz check this improve suggestion

ihadeed
ihadeed approved these changes Feb 27, 2021
View reviewed changes
Copy link
Collaborator

@ihadeed ihadeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsogl danielsogl changed the title Update Network plugin feat(network): update Network plugin Apr 5, 2021
@danielsogl danielsogl merged commit 31ee7ef into danielsogl:master Apr 5, 2021
@EinfachHans
Copy link
Contributor

Please see #3649 which is caused by this PR

@EinfachHans EinfachHans mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsogl danielsogl danielsogl approved these changes

@ihadeed ihadeed ihadeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkovik @EinfachHans @ihadeed @danielsogl