Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Lib update #1921

Merged
merged 1 commit into from
Aug 26, 2017
Merged

HTTP Lib update #1921

merged 1 commit into from
Aug 26, 2017

Conversation

troyanskiy
Copy link
Contributor

Hello.

Since the repository https://github.com/wymsee/cordova-HTTP is no longer maintained I would like to propose to switch to a fork of the plugin which is maintained nicely.
Thanks.

@mburger81
Copy link
Contributor

this pull request resolves my issue #1883 opened some weeks ago

@Lestjer
Copy link

Lestjer commented Aug 30, 2017

after the update when i try to use the plugin, says the HTTP plugin is not installed

@troyanskiy troyanskiy deleted the http-improvements branch August 30, 2017 14:37
@troyanskiy
Copy link
Contributor Author

@Lestjer
Will check that.
Thanks

@troyanskiy
Copy link
Contributor Author

@Lestjer did you uninstall the old plugin and installed the new one?
ionic cordova plugin rm cordova-plugin-http
ionic cordova plugin add cordova-plugin-advanced-http

@Lestjer
Copy link

Lestjer commented Aug 30, 2017

@troyanskiy
I recently installed the plugin in my app, it wasn't an update, and I created a new app to test, but it doesn't work either

@troyanskiy
Copy link
Contributor Author

Indeed. With my old project it works, but if install new from scratch it does not work.
There was the wrong reference in HTTP plugin wrapper.
I have created new PR to fix that.
Thank you @Lestjer for the test!

@silkimen
Copy link
Contributor

Hi guys,

I just realised that you are using our version of the HTTP plugin. We are planning to throw out AngularJS (Angular 1.x) support in the next release. See https://github.com/silkimen/cordova-plugin-advanced-http/blob/master/www/angular-integration.js#L4-L87

Will this affect your ionic native integration? I don't think so, but I wanted to ask you first.

@troyanskiy
Copy link
Contributor Author

@silkimen Hi! First of all, thank you for supporting the plugin.
I do not think that it will break something because normally ionic has there are own wrappers.

@Lestjer
Copy link

Lestjer commented Aug 31, 2017

@troyanskiy

I Don't know if I'm missing something, but it still does not work, same message:

Native: tried calling HTTP.get, but the HTTP plugin is not installed
Install the HTTP plugin: 'ionic cordova plugin add cordova-plugin-advanced-http'

@troyanskiy
Copy link
Contributor Author

@Lestjer the fix has been merged, but not yet pushed to npm.

@mburger81
Copy link
Contributor

Hi @silkimen ionic has his own wrapper, as you see now we have your beautiful plugin here :)

@flowli
Copy link

flowli commented Sep 6, 2017

@troyanskiy Please let us know when the update is available via npm - we need SSL pinning, too :-)

@troyanskiy
Copy link
Contributor Author

Hello @flowli
Unfortunately, I have no idea when it will be pushed to npm, I'm not an Ionic team member. :)
This question probably should be addressed to @ihadeed .

@flowli
Copy link

flowli commented Sep 6, 2017

@troyanskiy Thanks for your reply.
@ihadeed Then I ask you :-) Is there any chance of this landing on npm soon? ;-)

@ihadeed
Copy link
Collaborator

ihadeed commented Sep 6, 2017

@troyanskiy
Copy link
Contributor Author

@ihadeed I think the subject is about PR #1934

@CiPhantom
Copy link

i still have same issue

@arabishoo
Copy link

2020 and am having this issue still.. tried everything.. is there any update? do you recommend anything else?

@jhosilvo
Copy link

2020 and am having this issue still.. tried everything.. is there any update? do you recommend anything else?

try call it after platform.ready, it's possible that you are calling the plugin before it's started.

this.platform.ready().then(() => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants