Secure Storage in Ionic Native missing secureDevice function

[surajrao]

I'm submitting a ... (check one with "x")
[] bug report
[x ] feature request

Current behavior:
The current SecureStorage wrapper does not support secureDevice(successHandler,errorHandler) function which is present in the cordova plugin for android platform.

Also check this stackoverflow question

Expected behavior:
Should be able to do:

var ss = this.secureStorage.create('myStorage')
                .then((storage: SecureStorageObject) => {
                    storage.set('var', 'toto')
                        .then(
                        () => ss.secureDevice(()=>{},()=>{}),
                        (e) => console.log('error');
                        );
                }).catch((err) => {
                    console.error('The device is not secured');
                })

Steps to reproduce:

Use the latest ionic blank app and try to access secureDevice function.

Apologies if I should have raised this with main ionic repo or at the cordova plugin repo. Please let me know.

[danielsogl]

@surajrao I added the missing function. Wait for the next release

[surajrao]

thank you @danielsogl

[irundaia]

Hi guys,

Unless I'm mistaken, this feature will not work. The promise that returns the SecureStorageObject (SecureStorage.create('secure_storage')) already fails with a Device is not secure error. Therefore, we never get the SecureStorageObject on which we can call the secureDevice method.

[irundaia]

@surajrao How would this work? The ss variable is a Promise<void>. So there isn't a function called secureDevice on ss?

[surajrao]

@irundaia Oh you are right.. https://github.com/Crypho/cordova-plugin-secure-storage/blob/master/www/securestorage.js#L266 The function does need SecureStorageObject which you will not have in catch.

[Servuc]

Hey everybody,

Does this bug will be close ?
More over, it's seem that solution works : https://stackoverflow.com/questions/46520464/ionic-secure-storage-ask-the-user-to-set-a-lock-screen/46583135#46583135

Have a good day ;)

[irundaia]

The solution implies that you’d have to patch the javascript code from ionic-native. To me, that does not sound like a solution but a hack.

[Servuc]

Right, after doing some tests, it seems not work on iOS ...
I don't exactly how Ionic "wrapper" from Cordova works, somebody knows ?

[Servuc]

Hey,

After some projects update to last version (in package.json), I've a new problem. Apple detection is weak. 95% of the time, app said that phone is unsecure. I do not have that bug on Android
Am I the only one ?

I will give more information if I success to debug iOS app from Linux (with Remote IOS Debug)

Have a good coding day