Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the jscs.json file to a later config from angular.
The first commit also runs the fixes on
js/angular
.I did a separate commit to run jscs on the rest of the
js/
files. Not sure if that is desired?It removes
"excludeFiles": ["src/ngLocale/**"],
since that isn't needed.Also, I didn't add the
"disallowKeywordsOnNewLine": ["else"],
since there are comments between if and else.Maybe we should add another rule for whitespace in parens?
I see some
if( (len = itemsEntering.length) ) {
orif ( ionic.keyboard.height ) {
I'm using the to-be-released autofixing feature in jscs (in master). Right now it works for mostly white space changes. It was able to get 406/408 errors in the rest of the
js/
folder.