Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using scope properties with the tab directive attributes produces a has no method 'setAttribute' error #490

Closed
gregaton opened this issue Jan 29, 2014 · 4 comments
Milestone

Comments

@gregaton
Copy link

Currently the Ionic tab directive only seems to understand the {{property}} syntax when it comes to using scope properties to set attributes of the tab directive.

While this seems to work just fine it also produces an error message for every attribute this is used on: Object #<Comment> has no method 'setAttribute'

Here's a plunker that reproduces the problem using ng-repeat. The problem also exists without ng-repeat, this example is just closer to my current use case:

http://plnkr.co/edit/928wciFp8hmRrOTtlEYP?p=preview
(You have to open the console and refresh the page to see the error messages).

Below is a full error message from the console.

TypeError: Object #<Comment> has no method 'setAttribute'
    at forEach.attr (http://code.ionicframework.com/nightly/js/angular/angular.js:2462:15)
    at Object.JQLite.(anonymous function) [as attr] (http://code.ionicframework.com/nightly/js/angular/angular.js:2569:9)
    at Object.Attributes.$set (http://code.ionicframework.com/nightly/js/angular/angular.js:5430:28)
    at Object.interpolateFnWatchAction [as fn] (http://code.ionicframework.com/nightly/js/angular/angular.js:6534:28)
    at Scope.$digest (http://code.ionicframework.com/nightly/js/angular/angular.js:11802:29)
    at Scope.$apply (http://code.ionicframework.com/nightly/js/angular/angular.js:12055:24)
    at http://code.ionicframework.com/nightly/js/angular/angular.js:1301:15
    at Object.invoke (http://code.ionicframework.com/nightly/js/angular/angular.js:3704:17)
    at doBootstrap (http://code.ionicframework.com/nightly/js/angular/angular.js:1299:14)
    at bootstrap (http://code.ionicframework.com/nightly/js/angular/angular.js:1313:12)
@adamdbradley adamdbradley modified the milestones: 0.9.25, 1.0 Beta Feb 3, 2014
@ajoslin ajoslin modified the milestones: 0.9.25, 0.9.26 Feb 17, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Feb 17, 2014

Moved to 0.9.26

@ajoslin ajoslin added the tabs label Feb 21, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Feb 25, 2014

Fixed via 0f1b6f4

@ajoslin ajoslin closed this as completed Feb 25, 2014
@gregaton
Copy link
Author

gregaton commented Mar 5, 2014

I finally managed to upgrade to 0.9.26.
Sadly the error message still exists.
I've updated the plunker to 0.9.26 so you can see the problem here:
http://plnkr.co/edit/928wciFp8hmRrOTtlEYP?p=preview

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants