Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Modal header is below tabs-top on iOS Cordova #3346

Closed
mikejpeters opened this issue Mar 17, 2015 · 6 comments · Fixed by #3347
Closed

bug: Modal header is below tabs-top on iOS Cordova #3346

mikejpeters opened this issue Mar 17, 2015 · 6 comments · Fixed by #3347
Assignees

Comments

@mikejpeters
Copy link

Type: bug

Platform: ios 7 webview

http://codepen.io/mikejpeters/pen/azQQdV

When top tabs are used within a modal, the modal header is incorrectly displayed below the tabs on iOS with Cordova (when the body has the platform-ios and platform-cordova classes).

@mikejpeters
Copy link
Author

Related to issue #3011

@mhartington mhartington added the needs: reply the issue needs a response from the user label Mar 30, 2015
@mhartington
Copy link
Contributor

Quick question, is the purpose of tabs in the modal to create a nested navigation structure?

@mikejpeters
Copy link
Author

Yes (e.g. to have an "Edit" modal that contains tabs for organizing the editable data); I assumed this is supported because there seems to be css in _modal.scss specifically for tabs.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Mar 30, 2015
@mhartington
Copy link
Contributor

So the issue was the has-tabs-top class on the header bar.
Should be good now.

http://codepen.io/mhartington/pen/qEzxjM

@mikejpeters
Copy link
Author

Yes the issue is not present unless the has-tabs-top class is present, but I think it's still valid. I want my header to blend with my top tabs, which means I need to use the has-tabs-top class according to the documentation.

That is specifically what I have tried to address with my pull request.

@mhartington mhartington self-assigned this Apr 10, 2015
@mhartington
Copy link
Contributor

Hmm, alright so I see where the confusion is. So has-tabs-top is used a few places in our css.

  1. For header-bars when the tabs are on top
  2. For ion-content when tabs are on top

But it seems that the styles from 2 are effecting 1.
Will with the team about merging the fix. Just don't want to introduce any possible bugs.

@mhartington mhartington reopened this Apr 10, 2015
@tlancina tlancina assigned tlancina and unassigned mhartington Apr 10, 2015
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants