[BUG] [IMPORTANT] collection-repeat last changes are breaking-changes

[rbecheras]

I just update from beta.10 to beta.11 on my actual project.
I notice a breaking change on collection-repeat that I don't understand, and that is not documented on release notes : https://github.com/driftyco/ionic/releases/tag/v1.0.0-beta.11
This change is just annonced as feature : 7ddb57e

But it seems that there is a "shift-up" in the rendered items causing :

• the first one is not rendered (top),
• and the last one is empty (bottom).

Thus, for example if you sort your items by "date DESC":

• the last is not rendered,
• and the older is rendered with empty properties.

This causes also an issue by shifting the height (given by getHeight() implementation) of the elements that no longer match the correct elements. Then, sometimes an item start under the previous, somtimes an item stop and the folowing start some blanc pixel later.

So I think the following issue contain the mistake but this update is pretty huge, so I can't go forward (time, not pleasure ;-) )

I did downgrade to beta.10 for now to recover this issue.

[shiftynick]

I'm seeing the same thing.

[felquis]

The same issue here, I spend about 10 hours debugging my code to find where I'm wrong, so I saw this issue and I regressed ionic to beta 10 and everything worked like a charm.

I can send prints if necessary

[shiftynick]

With more testing I actually will either see the above described behavior - OR - only the first element in the list. If I reload a page with a collection-repeat on it, I get each behavior about half of the time.

[Gelurban]

I'm having the same issue :(
First item in the collection is not rendered. Last item is a "ghost" item with no properties.

[rbecheras]

Reviewing the sources file changes , intuitively, I focused on this changes, lines 260-264 of the old version, and 279-281 of the new one.
Maybe its not the issue at all, but it may be a clue for that who will work on this issue.
I left two line-comments into the change-diff :

• 7ddb57e#commitcomment-7566153
• 7ddb57e#commitcomment-7566206

[rbecheras]

Sorry closing the issue was not intentional at all. So I reopened it.

[mjason3]

any updates on ghost item at last?

[rbecheras]

Not yet.

[rbecheras]

It seems that beta-12 provide some fixes about collection-repeat, in particular this one : 9bfa3bd

If it's the case, this issue is a duplicate of this one: #1970
It was fixed, and the issue should be closed.

But I can't check if the issue is fixed at this time.
Is there someone to try to reproduce this issue with beta-12 and informe us about the result ?

[felquis]

I can confirm this, beta 12 fixed this! :D (including other bugs not listed in this thread)

I think everything is working fine!

[adamdbradley]

thanks for confirming it work!

[rbecheras]

Thank you @felquis , @adamdbradley

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.