-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Page able to be dragged horizontally #1285
Comments
Any update on this one guys? |
I'm seeing this since beta 4 in our app, too - you can drag the entire app to the left by grabbing the header or tab bar (but not the content area). |
Sorry about this, we've had our heads down this past week still creating proper testing infrastructure. It's very close to done. What is it? Well, long story short, protractor will go through demos.ionicframework.com, interact with the app, take screenshots of stage of its interaction, and compare those screenshots with the previous tests' screenshots. Tools like Huxley inspired this, but Huxley isn't maintained and doesn't work with remote browser testing on Saucelabs. Protractor does. Most of the work is building out the demos and building out our screenshot comparing server. More info on this soon, we'll be blogging about it for sure. I'll get to this bug soon, once we finish this testing infrastructure. |
@ajoslin some more issues with this in beta 6. http://forum.ionicframework.com/t/1px-gap-on-right-header/5002/3 |
Hi, Problem is with styles for header buttons on right side and more precisely with margin-right for pseudo element :after which is responsible for larger hit area. After change it on -6px everything is ok. |
Figured out the cause of the problem for us, but don't have a solution yet. We have an ion-nav-bar with ion-views that don't use a title (we have a global search form) and when the title is missing or empty, the ion-nav-bar empty title gets a left and right sizing of 634px on iOS, which makes a horizontal scrollbar. Removing the empty h1 fixes the problem. As this is created in a directive we'd rather not have to edit the Ionic bundle code directly. Not sure where the sizing issue is happening yet, but if I can figure it out I'll submit a PR. |
Changing :after style to -6px right also fixes the problem for me. Thanks. |
Thanks for the details all, I'm fixing this now. |
OK, so it doesn't look like there's a |
I've since update to newer versions of ionic and this bug wasn't a problem. So, perhaps it's already fixed? |
Still have the problem with the latest nightly. |
@jough I actually cannot reproduce the exact error you described: on iOS, the title text being improperly adjusted with In fact, when there is no text, I am unable to get the title to have any styles applied to it at all. |
@jough can you post code that reproduces this? |
@jough, since it's been a month, I'm going to assume the latest beta has fixed the issue. Let me know if that's not the case. |
I can still reproduce this issue with Beta 14 on iOS. An overflow shift would automatically happen when a It's specifically The best/simplest fix I could find was just adding |
Can you provide a simple codepen that can replicate this? |
Best reproduce case I've found so far is at http://ionicframework.com/demos/collection-repeat.
Drag the header left or right.
Mentioned in #1157
The text was updated successfully, but these errors were encountered: