Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Page able to be dragged horizontally #1285

Closed
ajoslin opened this issue May 6, 2014 · 16 comments
Closed

iOS: Page able to be dragged horizontally #1285

ajoslin opened this issue May 6, 2014 · 16 comments
Assignees
Labels
needs: reply the issue needs a response from the user

Comments

@ajoslin
Copy link
Contributor

ajoslin commented May 6, 2014

Best reproduce case I've found so far is at http://ionicframework.com/demos/collection-repeat.

Drag the header left or right.

Mentioned in #1157

@ajoslin ajoslin self-assigned this May 6, 2014
@robdmoore
Copy link

Any update on this one guys?

@jough
Copy link

jough commented May 29, 2014

I'm seeing this since beta 4 in our app, too - you can drag the entire app to the left by grabbing the header or tab bar (but not the content area).

@ajoslin
Copy link
Contributor Author

ajoslin commented May 29, 2014

Sorry about this, we've had our heads down this past week still creating proper testing infrastructure. It's very close to done.

What is it? Well, long story short, protractor will go through demos.ionicframework.com, interact with the app, take screenshots of stage of its interaction, and compare those screenshots with the previous tests' screenshots.

Tools like Huxley inspired this, but Huxley isn't maintained and doesn't work with remote browser testing on Saucelabs. Protractor does. Most of the work is building out the demos and building out our screenshot comparing server. More info on this soon, we'll be blogging about it for sure.

I'll get to this bug soon, once we finish this testing infrastructure.

@mhartington
Copy link
Contributor

@ajoslin some more issues with this in beta 6.

http://forum.ionicframework.com/t/1px-gap-on-right-header/5002/3

@ghost
Copy link

ghost commented May 30, 2014

Hi,

Problem is with styles for header buttons on right side and more precisely with margin-right for pseudo element :after which is responsible for larger hit area.

After change it on -6px everything is ok.

@jough
Copy link

jough commented May 30, 2014

Figured out the cause of the problem for us, but don't have a solution yet.

We have an ion-nav-bar with ion-views that don't use a title (we have a global search form) and when the title is missing or empty, the ion-nav-bar empty title gets a left and right sizing of 634px on iOS, which makes a horizontal scrollbar. Removing the empty h1 fixes the problem.

As this is created in a directive we'd rather not have to edit the Ionic bundle code directly. Not sure where the sizing issue is happening yet, but if I can figure it out I'll submit a PR.

@udfalkso
Copy link

udfalkso commented Jun 2, 2014

Changing :after style to -6px right also fixes the problem for me. Thanks.

@ajoslin
Copy link
Contributor Author

ajoslin commented Jun 24, 2014

Thanks for the details all, I'm fixing this now.

@ajoslin
Copy link
Contributor Author

ajoslin commented Jun 24, 2014

OK, so it doesn't look like there's a margin-right: -6px rule for the buttons' :after rule, do you mean the right: -6px rule?

@udfalkso
Copy link

I've since update to newer versions of ionic and this bug wasn't a problem. So, perhaps it's already fixed?

@jough
Copy link

jough commented Jun 24, 2014

Still have the problem with the latest nightly.

@ajoslin
Copy link
Contributor Author

ajoslin commented Jun 25, 2014

@jough I actually cannot reproduce the exact error you described: on iOS, the title text being improperly adjusted with left and right styles when there is no title text.

In fact, when there is no text, I am unable to get the title to have any styles applied to it at all.

@ajoslin
Copy link
Contributor Author

ajoslin commented Jul 6, 2014

@jough can you post code that reproduces this?

@perrygovier
Copy link
Contributor

@jough, since it's been a month, I'm going to assume the latest beta has fixed the issue. Let me know if that's not the case.

@lunaroja
Copy link

I can still reproduce this issue with Beta 14 on iOS. An overflow shift would automatically happen when a select was triggered on device/simulator. You could see a white 1px line on the right side.

It's specifically .bar .title + .buttons { right: 5px; } that is causing the issue. Changing to right: 6px;` does solve the issue.

The best/simplest fix I could find was just adding .bar { overflow: hidden; } to my project. I have not seen any negative impact because of that added rule, so it might be worth adding it to _bar.scss.

@mhartington
Copy link
Contributor

Can you provide a simple codepen that can replicate this?

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

7 participants