Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts in RTL apps appears LTR #10147

Closed
theunreal opened this issue Jan 23, 2017 · 4 comments
Closed

Alerts in RTL apps appears LTR #10147

theunreal opened this issue Jan 23, 2017 · 4 comments
Assignees

Comments

@theunreal
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[x ] 2.x

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
When creating a new alert, the alert is left to right, although the application is rtl (dir="rtl")

Expected behavior:
Alerts appear as from right to left

Related code:
Create any alert in rtl app

let alert = this.alertCtrl.create({
     title: 'Text from right to left',
     subTitle: 'shows as ltr',
     buttons: ['Verify']
   });
   alert.present();

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Ionic 2 Rc.5
@mhartington
Copy link
Contributor

Quick check, we could change this value to start instead of hard-coding it left.

https://github.com/driftyco/ionic/blob/3282c95e9b292417f41f9658e87572930cfb931e/src/components/alert/alert.md.scss#L24-L25

@mohamedsharaf
Copy link

confirm #9815

@jgw96
Copy link
Contributor

jgw96 commented Apr 7, 2017

Hello, thanks for using Ionic! We really appreciate this feedback on RTL support. This is not currently high priority for us at the moment, but we are tracking it in #5035. Because of this I am going to close this issue as a duplicate of that issue and ask that you put your feedback on that issue. Please know that by me closing this issue I am not saying that your feedback is not important, or that RTL support is not important, but I am simply closing this issue as we like to keep our issues as organized as possible so things do not get lost in the weeds (which is better said than done haha).

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants