From 2c8d5939b962bdd876d3599942a385427cf5a43d Mon Sep 17 00:00:00 2001 From: Justin Willis Date: Mon, 9 May 2016 13:05:07 -0500 Subject: [PATCH 1/3] chore(): add note about markdown formatting --- .github/ISSUE_TEMPLATE.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 93d54d20af8..89ea01b53c7 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,3 +1,6 @@ +**Note: If you are having problems formatting your issue please refer to this article on using markdown in Github:** +https://guides.github.com/features/mastering-markdown/ + **Note: for support questions, please use one of these channels:** https://forum.ionicframework.com/ @@ -35,3 +38,4 @@ insert any relevant code between the above and below backticks **Run `ionic info` from terminal/cmd prompt:** (paste output below) + From fa0ba4d1a5eaf0ea56f481b709aa2cb36ef19d2b Mon Sep 17 00:00:00 2001 From: Justin Willis Date: Mon, 9 May 2016 13:07:48 -0500 Subject: [PATCH 2/3] chore(): fix formatting issue --- .github/ISSUE_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 89ea01b53c7..f38f442a2ee 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,5 @@ **Note: If you are having problems formatting your issue please refer to this article on using markdown in Github:** + https://guides.github.com/features/mastering-markdown/ **Note: for support questions, please use one of these channels:** From ea57b4125ba6c058926b8e3de4edb960a03adde5 Mon Sep 17 00:00:00 2001 From: Justin Willis Date: Mon, 9 May 2016 13:28:33 -0500 Subject: [PATCH 3/3] fix(scroll): values should be pixel values According to the unit tests this expects pixel values. --- js/angular/controller/refresherController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/angular/controller/refresherController.js b/js/angular/controller/refresherController.js index a3a2045ff3d..c1a0d5fa4f1 100644 --- a/js/angular/controller/refresherController.js +++ b/js/angular/controller/refresherController.js @@ -170,7 +170,7 @@ IonicModule } function overscroll(val) { - scrollChild.style[ionic.CSS.TRANSFORM] = 'translate3d(0, ' + val + 'px, 0)'; + scrollChild.style[ionic.CSS.TRANSFORM] = 'translate3d(0px, ' + val + 'px, 0px)'; lastOverscroll = val; }