From e4b5c593b1af2f06be6922828f84f418e3f55c9e Mon Sep 17 00:00:00 2001
From: Dan Bucholtz <dan.bucholtz@gmail.com>
Date: Wed, 28 Jun 2017 14:36:52 -0500
Subject: [PATCH] fix(bonjour): remove bonjour as its causing trouble for users
 on Windows without git

---
 src/dev-server/bonjour.ts | 28 ----------------------------
 src/serve.ts              |  8 +-------
 2 files changed, 1 insertion(+), 35 deletions(-)
 delete mode 100644 src/dev-server/bonjour.ts

diff --git a/src/dev-server/bonjour.ts b/src/dev-server/bonjour.ts
deleted file mode 100644
index a2c8f26c..00000000
--- a/src/dev-server/bonjour.ts
+++ /dev/null
@@ -1,28 +0,0 @@
-import { Logger } from '../logger/logger';
-import { getProjectJson } from '../util/ionic-project';
-import { ServeConfig } from './serve-config';
-
-export function createBonjourService(config: ServeConfig) {
-  if (!config.devapp) {
-    return;
-  }
-  getProjectJson()
-    .then(project => project.name)
-    .catch(() => 'ionic-app-scripts')
-    .then(projectName => {
-      try {
-        const bonjour = require('bonjour')();
-        const name = projectName + ':' + config.httpPort;
-        bonjour.publish({
-          name: name,
-          type: 'ionicdev',
-          port: config.httpPort
-        });
-        Logger.info(`publishing devapp service (${name})`);
-
-      } catch (e) {
-        Logger.warn('bonjour failed when trying to publish service');
-        Logger.debug(e);
-      }
-    });
-}
diff --git a/src/serve.ts b/src/serve.ts
index c380c720..61d39bbe 100644
--- a/src/serve.ts
+++ b/src/serve.ts
@@ -8,7 +8,6 @@ import open from './util/open';
 import { createNotificationServer } from './dev-server/notification-server';
 import { createHttpServer } from './dev-server/http-server';
 import { createLiveReloadServer } from './dev-server/live-reload';
-import { createBonjourService } from './dev-server/bonjour';
 import { ServeConfig, IONIC_LAB_URL } from './dev-server/serve-config';
 import { findClosestOpenPorts } from './util/network';
 
@@ -47,7 +46,7 @@ export function serve(context: BuildContext) {
         useServerLogs: useServerLogs(context),
         useProxy: useProxy(context),
         notifyOnConsoleLog: sendClientConsoleLogs(context),
-        devapp: useBonjour(context)
+        devapp: false
       };
 
       createNotificationServer(config);
@@ -57,7 +56,6 @@ export function serve(context: BuildContext) {
       return watch(context);
     })
     .then(() => {
-      createBonjourService(config);
       onReady(config, context);
       return config;
     }, (err: BuildError) => {
@@ -143,10 +141,6 @@ function browserOption(context: BuildContext): string {
   return getConfigValue(context, '--browseroption', '-o', 'IONIC_BROWSEROPTION', 'ionic_browseroption', null);
 }
 
-function useBonjour(context: BuildContext): boolean {
-  return hasConfigValue(context, '--devapp', '-D', 'devapp', false);
-}
-
 function launchLab(context: BuildContext): boolean {
   return hasConfigValue(context, '--lab', '-l', 'ionic_lab', false);
 }