From 77edbc65962865151f51d8bb764b034739f8512f Mon Sep 17 00:00:00 2001 From: Marco Rosi Date: Fri, 21 Apr 2017 21:41:35 +0200 Subject: [PATCH] fix(serve): Fix for browser not opening on linux, fixes #425 (#909) --- src/serve.ts | 6 +++++- src/util/open.ts | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/serve.ts b/src/serve.ts index 57c3388f..d6ff78cb 100644 --- a/src/serve.ts +++ b/src/serve.ts @@ -76,7 +76,11 @@ function onReady(config: ServeConfig, context: BuildContext) { .concat(browserOption(context) ? [browserOption(context)] : []) .concat(platformOption(context) ? ['?ionicplatform=', platformOption(context)] : []); - open(openOptions.join(''), browserToLaunch(context)); + open(openOptions.join(''), browserToLaunch(context),(error:any) => { + if (error) { + Logger.warn(`Sorry.. unable to open the browser for you: ${error}`); + } + }); } Logger.info(`dev server running: ${config.hostBaseUrl}/`, 'green', true); Logger.newLine(); diff --git a/src/util/open.ts b/src/util/open.ts index 525ecc82..ca230fad 100644 --- a/src/util/open.ts +++ b/src/util/open.ts @@ -43,8 +43,8 @@ export default function (target: string, appName: string | Function, callback?: if (typeof appName === 'string') { opener = escape(appName); } else { - // use Portlands xdg-open everywhere else - opener = path.join(__dirname, '../vendor/xdg-open'); + //use system installed Portlands xdg-open everywhere else + opener = 'xdg-open'; } break; }