fix(serve): Fix for browser not opening on linux, fixes #425 (#909)

ionic-team · Apr 21, 2017 · 77edbc6 · 77edbc6
1 parent a8616eb
commit 77edbc6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/serve.ts b/src/serve.ts
@@ -76,7 +76,11 @@ function onReady(config: ServeConfig, context: BuildContext) {
       .concat(browserOption(context) ? [browserOption(context)] : [])
       .concat(platformOption(context) ? ['?ionicplatform=', platformOption(context)] : []);
 
-    open(openOptions.join(''), browserToLaunch(context));
+    open(openOptions.join(''), browserToLaunch(context),(error:any) => {
+      if (error) {
+        Logger.warn(`Sorry.. unable to open the browser for you: ${error}`);
+      }
+    });
   }
   Logger.info(`dev server running: ${config.hostBaseUrl}/`, 'green', true);
   Logger.newLine();

diff --git a/src/util/open.ts b/src/util/open.ts
@@ -43,8 +43,8 @@ export default function (target: string, appName: string | Function, callback?:
     if (typeof appName === 'string') {
       opener = escape(appName);
     } else {
-      // use Portlands xdg-open everywhere else
-      opener = path.join(__dirname, '../vendor/xdg-open');
+      //use system installed Portlands xdg-open everywhere else
+      opener = 'xdg-open';
     }
     break;
   }