-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2.0] Platform not recognizing ios #556
Comments
I can't reproduce And in any case, it would be an ionic bug, not a plugin bug, since the platform logic is implemented there |
I also see this issue. On 5.0.0 I have the following platforms listed when running on an ipad: cordova,mobile,hybrid. With version 4.1.3 I see: ipad,ios,tablet,cordova,mobile,hybrid. As such my app uses material icons and has interesting (incorrect) font choices when run on iPad with 5.0.0. If I simply go back to the 4.1.3 plugin everything looks fine. |
This is an issue with this plugin, not something with the platform. If the platform was wrong then you were supporting it and making people dependent on this error. Perhaps Ionic 5 does not suffer from this issue, but 4.x does. These lines were removed from CDVWKWebViewEngine.m in 4.2.0 and their absence is the cause: Perhaps you needed to else if that on your new overrideUserAgent check on line 279? Doing that solves the problem for me:
|
Then report a new issue and provide a sample app where can be reproduced. |
Hi. Just to add I'm currently upgrading an app with this plugin version 1.2.1 to version 5.0.0 with Ionic 3.9.9. Ionic v3 uses the userAgent to set the platform and then set appropriate styling. See https://github.com/ionic-team/ionic-v3/blob/master/src/platform/platform-registry.ts#L123 I don't know if this should be fixed/changed in this plugin or in Ionic 3 (which seems abandoned), or something we have to patch together ourselves for Ionic 3. There are several issues reported in the v3 repository:
The documentation for this plugin should at least be updated to say it's not compatible with Ionic 3 until a fix or workaround is available On actual device on iPad 6th gen - iPadOS 14 (18A373 - I have the public beta profile installed, but I assume this is the 14 GM) 1.2.1: 4.1.3: 4.2.0: 5.0.0: ionic info with 5.0.0 installed:
|
Hi I tried this solution, but under iOS 14, i have the error IOS build failed for IOS 14 - Property ‘userAgent’ not found on object of type ‘CDVViewController *’ |
Hi,
|
Tested on real iPad 13.1.3:
Returns always
false
.On the other hand:
Evals
true
The text was updated successfully, but these errors were encountered: