fix(ios): Present js alert on top of the presented VC #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ionic-team/capacitor-plugins#713
If a js alert is used while the capacitor view controller is presenting another view (in 713 it's a native alert), the app crash because the js alert is not being presented
This PR changes the behavior to detect if another view controller is being presented and present the js alert on top of that view controller instead of in the capacitor view controller.
Not sure if this could be considered a breaking change since at the moment the js alert is not being presented. An alternative would be to not try to present the js alert if capacitor view controller is presenting another view controller, that should also avoid the crash.