-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better ignore rules for npm distribution #32
Conversation
motion/.npmignore
Outdated
android/.gradle | ||
ios/Pods | ||
ios/Podfile.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
motion is web only, so doesn't have any of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this, but I'm fine specializing it
I think it should ignore everything that is in the gitignore too |
Okay, I investigated this. git and npm treat gitignore slightly differently.
diff --git a/0 b/1
index 70a8c7d..6756aa0 100644
--- a/0
+++ b/1
@@ -1,3 +1,4 @@
+.prettierignore
CHANGELOG.md
CapacitorTextZoom.podspec
LICENSE
@@ -44,3 +45,8 @@ ios/PluginTests/Info.plist
ios/PluginTests/PluginTests.swift
ios/Podfile
package.json
+rollup.config.js
+src/definitions.ts
+src/index.ts
+src/ios.ts
+tsconfig.json So, there are still files we shouldn't distribute ( |
fixes #27
see ionic-team/create-capacitor-plugin#3