Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better ignore rules for npm distribution #32

Merged
merged 8 commits into from
Sep 3, 2020
Merged

fix: better ignore rules for npm distribution #32

merged 8 commits into from
Sep 3, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Sep 1, 2020

@imhoffd imhoffd requested a review from jcesarmobile September 1, 2020 20:42
Comment on lines 1 to 3
android/.gradle
ios/Pods
ios/Podfile.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

motion is web only, so doesn't have any of this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this, but I'm fine specializing it

@jcesarmobile
Copy link
Member

I think it should ignore everything that is in the gitignore too

@imhoffd
Copy link
Contributor Author

imhoffd commented Sep 2, 2020

I think it should ignore everything that is in the gitignore too

Okay, I investigated this. git and npm treat gitignore slightly differently.

diff --git a/0 b/1
index 70a8c7d..6756aa0 100644
--- a/0
+++ b/1
@@ -1,3 +1,4 @@
+.prettierignore
 CHANGELOG.md
 CapacitorTextZoom.podspec
 LICENSE
@@ -44,3 +45,8 @@ ios/PluginTests/Info.plist
 ios/PluginTests/PluginTests.swift
 ios/Podfile
 package.json
+rollup.config.js
+src/definitions.ts
+src/index.ts
+src/ios.ts
+tsconfig.json

So, there are still files we shouldn't distribute (src/, configuration files, etc)

@imhoffd imhoffd requested a review from jcesarmobile September 3, 2020 18:36
@imhoffd imhoffd changed the title fix: only distribute necessary files fix: better ignore rules for npm distribution Sep 3, 2020
@imhoffd imhoffd merged commit b8d55b9 into main Sep 3, 2020
@imhoffd imhoffd deleted the npmignore branch September 3, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore certain files when publishing
2 participants