Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 #40

Closed
sverhoeven opened this issue Oct 13, 2020 · 5 comments
Closed

Support Python 3.9 #40

sverhoeven opened this issue Oct 13, 2020 · 5 comments

Comments

@sverhoeven
Copy link
Member

Does the library support Python 3.9? If so please add classifier in setup.py and run 3.9 on CI matrix.

@florian-huber
Copy link
Member

Good point! I was also thinking of it yesterday when I found something like python>=3.7 somewhere in the code.
Which CI runs do we have to include in you opinion?
The pip runs are fast so that can be included, but do we have to run the Anaconda verify for all (3x3 cases), or can we skip some cases in the CI?

@florian-huber
Copy link
Member

Started adding 3.9 to PR #39 .

@florian-huber
Copy link
Member

OK, that gave failling tests. So I will not add it as part of PR #39 but we should handle that in a separate PR.

@sverhoeven
Copy link
Member Author

The Conda package is pinned to python >=3.7,<3.9 and is noarch so having a matrix for anaconda_build does not make sense to me. As during publish job only the build artifact of py37+ubuntu-latest is published so why should we do more combinations for each push.

Having the full matrix for anaconda_verify is useful because the conda package can be installed with all those combis.

@florian-huber
Copy link
Member

Fixed with #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants