From 88afc4ac6e02af1e4c1a2dd6a41e4b46346699f0 Mon Sep 17 00:00:00 2001
From: Ioannis Tsanaktsidis <ioannis.tsanaktsidis@cern.ch>
Date: Thu, 7 Dec 2017 10:56:27 +0100
Subject: [PATCH] cli: fixes replace method

 * Closes #2039.

Signed-off-by: Ioannis Tsanaktsidis <ioannis.tsanaktsidis@cern.ch>
Co-authored-by: Pamfilos Fokianos <pamfilosf@gmail.com>
---
 cernopendata/modules/fixtures/cli.py | 43 +++++++++++++++++++++-------
 1 file changed, 33 insertions(+), 10 deletions(-)

diff --git a/cernopendata/modules/fixtures/cli.py b/cernopendata/modules/fixtures/cli.py
index 97e29ffde5..f357a3bba6 100644
--- a/cernopendata/modules/fixtures/cli.py
+++ b/cernopendata/modules/fixtures/cli.py
@@ -55,10 +55,8 @@ def get_jsons_from_dir(dir):
     return res
 
 
-def create_record(schema, data, files, skip_files):
-    """Creates a new record."""
-    bucket = Bucket.create()
-
+def handle_record_files(data, bucket, files, skip_files):
+    """Handles record files."""
     for file in files:
         if skip_files:
             break
@@ -91,22 +89,44 @@ def create_record(schema, data, files, skip_files):
                                  str(e)))
             continue
 
+
+def create_record(schema, data, files, skip_files):
+    """Creates a new record."""
     id = uuid.uuid4()
     cernopendata_recid_minter(id, data)
     record = Record.create(data, id_=id)
     record['$schema'] = schema
-    RecordsBuckets.create(
-        record=record.model, bucket=bucket)
+    if not skip_files:
+        bucket = Bucket.create()
+        handle_record_files(data, bucket, files, skip_files)
+        RecordsBuckets.create(
+            record=record.model, bucket=bucket)
 
     return record
 
 
-def update_record(pid, schema, data):
+def update_record(pid, schema, data, files, skip_files):
     """Updates the given record."""
     record = Record.get_record(pid.object_uuid)
     record['$schema'] = schema
+    with db.session.begin_nested():
+        if record.files:
+            bucket_id = record.files.bucket
+            bucket = Bucket.get(bucket_id.id)
+            for o in ObjectVersion.get_by_bucket(bucket).all():
+                o.remove()
+                o.file.delete()
+            RecordsBuckets.query.filter_by(
+                record=record.model,
+                bucket=bucket
+            ).delete()
+            bucket_id.remove()
+    db.session.commit()
+    bucket = Bucket.create()
+    handle_record_files(data, bucket, files, skip_files)
     record.update(data)
-    record.commit()
+    RecordsBuckets.create(
+        record=record.model, bucket=bucket)
     return record
 
 
@@ -172,7 +192,8 @@ def records(skip_files, files, profile, verbose, mode):
                     try:
                         pid = PersistentIdentifier.get('recid', data['recid'])
                         if pid:
-                            record = update_record(pid, schema, data)
+                            record = update_record(
+                                pid, schema, data, files, skip_files)
                             action = 'updated'
                     except PIDDoesNotExistError:
                         record = create_record(schema, data, files, skip_files)
@@ -198,8 +219,10 @@ def records(skip_files, files, profile, verbose, mode):
                             'cannot replace it.'.format(
                                 data.get('recid')), err=True)
                         return
-                    record = update_record(pid, schema, data)
+                    record = update_record(
+                        pid, schema, data, files, skip_files)
                     action = 'updated'
+                record.commit()
                 db.session.commit()
                 click.echo(
                     ' Record recid {0} {1}.'.format(