Allow changes to columns in bokeh CDS #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: enhancement
philippjfr
commented
May 8, 2018
.travis.yml
Outdated
| @@ -29,7 +29,7 @@ install: | |||
| - conda info -a | |||
| - conda create -q -n test-environment python=$TRAVIS_PYTHON_VERSION flake8 scipy=1.0.0 numpy freetype nose pandas=0.22.0 jupyter ipython=5.4.1 param matplotlib=2.1.2 xarray | |||
| - source activate test-environment | |||
| - conda install -c conda-forge iris plotly flexx ffmpeg --quiet | |||
| - conda install -c conda-forge iris plotly flexx ffmpeg netcdftime --quiet | |||
There was a problem hiding this comment.
Unrelated to this PR but apparently required to get tests passing again.
jlstevens
reviewed
May 8, 2018
holoviews/plotting/bokeh/plot.py
Outdated
| length = [len(v) for v in source.data.values() if isinstance(v, (list, np.ndarray))] | ||
| not_updated = [k for k in source.data if k not in data] | ||
| new = [k for k in data if k not in source.data] | ||
| if ((not_updated and new_length and any(len(source.data[n]) != new_length[0] for n in not_updated)) |
There was a problem hiding this comment.
Not sure you need the initial not_updated as any([]) evaluates to false.
There was a problem hiding this comment.
I think that is also true for the check against new.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates a long-standing limitation in updating plots with elements where the dimensions change. Specifically the code that updates a CDS now checks whether the data needs to be replaced completely, which occurs in one of two conditions 1) there is a new column which does not match the length of old columns or 2) there is an old column which is not being updated which does not match the updated columns in length.
Here are some examples of what this allows (note the changes in the axis label and table column header):
Technically we could just always replace the data completely but a) that can be inefficient and b) it breaks
shared_datasource. I've double checked shared sources are not affected by this change.