Fixed comm creation and stream subscriber attachment #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That description makes sense as does the solution. There isn't too much changed code either. That said, I think the only way we can be sure that everything is working properly is by merging ASAP and building lots of stream examples. |
philippjfr
force-pushed
the
stream_comm_attach
branch
from
798552d to
be06b88
Compare
|
Test have passed. Want to add some unit tests (might be tricky) or should I just merge? |
|
There are some unit tests, which actually caught a bug in my initial attempts at this. So yes, I think it's ready to merge. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the top_level plot attached itself as a subscriber to all the streams found on the plot. Apart from being inefficient because any change to a stream would trigger replotting of the whole Layout, this could cause issues with one plot triggering range updates on another even though the second plot hadn't changed at all.
In this PR each subplot is given access to the comm which means each subplot can be responsible for updating themselves.