Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Visibility group #381

Closed
1 task done
manuxi opened this issue Feb 21, 2024 · 14 comments
Closed
1 task done

[bug]: Visibility group #381

manuxi opened this issue Feb 21, 2024 · 14 comments
Labels
bug 🐞 Something isn't working

Comments

@manuxi
Copy link

manuxi commented Feb 21, 2024

No existing issues.

  • There is no existing issue for my problem.

Describe the bug

I created two groups with one user in each. The user is also member of the admin group:
image
Shoiwing a widget works so far (e.g for user ft in group firetablet).
image

But: when I remove the users from admin group, the widget is hidden.

To Reproduce

Create user, group, use visibility on a widget.

Expected behavior

The widget is not hidden, if the user is member of a dedicated group.

Screenshots & Logfiles


Page or affected widget

Using "View in Widget"

Adapter version

2.9.32

js-controller version

5.0.19

Node version

v18.17.1

Operating system

Buanet v8

Additional context

No response

@manuxi manuxi added the bug 🐞 Something isn't working label Feb 21, 2024
@foxriver76
Copy link
Collaborator

Does it work if you define it with the permissions functionality in the project window? Currently these are two differrent functionalities which should be harmonized from my point of view

@manuxi
Copy link
Author

manuxi commented Feb 23, 2024

You mean this here? I already stumbled upon this but don't know what to do there. Although I'm admin I can#t change anything there...
image

@foxriver76
Copy link
Collaborator

foxriver76 commented Feb 23, 2024

You for sure logged in as admin? Only admin can edit those. (Username in the upper right corner displayed as admin)

And you can only edit permissions for other users than admin. Admin always has full access.

@manuxi
Copy link
Author

manuxi commented Feb 25, 2024

Logged in as admin. As always. Played around with it for hours. Did work neither in FF nor in Chrome. Deleted caches several times, tried inkognito mode. All checkboxes are greyed out (in source code the span has the attribute disabled=""):
image
Renamed my admin user, but this shouldn't affect this?

@ioBroker ioBroker locked as off-topic and limited conversation to collaborators Feb 26, 2024
@ioBroker ioBroker unlocked this conversation Feb 26, 2024
@foxriver76
Copy link
Collaborator

ah actually yes, the rename was a problem, I have pushed a fix

@foxriver76
Copy link
Collaborator

I will also try to reproduce the original issue.

@foxriver76
Copy link
Collaborator

foxriver76 commented Feb 26, 2024

I think regarding the initial issue it depends on the group permissions. If you login with a user, the socket connection also uses the "maybe" restricted permissions from the assigned group. Can you show me the configured access rights of the group? If read objects is missing try to set and re-check please.

And regarding the permissions system please try 2.9.34

@manuxi
Copy link
Author

manuxi commented Feb 27, 2024

Can't see v2.9.34, only 2.9.32 and 2.9.35.

Can you show me the configured access rights of the group?
image

@foxriver76
Copy link
Collaborator

hm okay from my expectation it looks good to me. If you give the group all access rights, does it also not display?

@manuxi
Copy link
Author

manuxi commented Feb 28, 2024

On v.2.9.36 I removed the tablet user from the admin group, left him in the tablet_fire group only. Set the permissions in the tablet_fire group to grant all permissions. Does not work.

@manuxi
Copy link
Author

manuxi commented Feb 28, 2024

[BTW] I can confirm that I can set permissions on project level now.
image

@foxriver76
Copy link
Collaborator

[BTW] I can confirm that I can set permissions on project level now. image

Not fixing the original problem, as it should work as well. However, are you able to reach your goal with these settings?

@foxriver76
Copy link
Collaborator

the original problem reminds me bit of this bug -> #251 (comment) maybe you could try the workaround from the linked comment

@manuxi
Copy link
Author

manuxi commented Feb 28, 2024

Thank you for that hint, perhaps I'll try this at some day. Seems to be a very complex issue...

@manuxi manuxi closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants