Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed problem with discovery dialog #2090

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fixed problem with discovery dialog #2090

merged 2 commits into from
Sep 1, 2023

Conversation

foxriver76
Copy link
Collaborator

if (typeof obj.common.licenseUrl === 'object') {
obj.common.licenseUrl = obj.common.licenseUrl[I18n.getLanguage()] || obj.common.licenseUrl.en;
}
if (obj.common.licenseUrl.includes('github.com')) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
github.com
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
{devicesProgress >= 99
? `Lookup services - ${servicesProgress}%`
: `Lookup devices - ${devicesProgress}%`}
{disableScanner && (

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'disableScanner' always evaluates to true.
@foxriver76 foxriver76 merged commit f52cabb into master Sep 1, 2023
14 of 15 checks passed
@foxriver76 foxriver76 deleted the issue-2089 branch September 1, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error
1 participant