Crop & Mask updates #6876
Open
Crop & Mask updates #6876
+105
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipsterusername
requested review from
blessedcoolant,
psychedelicious and
brandonrising
as code owners
github-actions
bot
added
python
hipsterusername
force-pushed
the
hipster/feat/mask-node-updates
branch
from
4367ae0 to
89ee803
Compare
…nvoke-ai/InvokeAI into hipster/feat/mask-node-updates
|
As I consider this - Perhaps it'd be better to have this just output the crop offsets for the identified object and let existing crop nodes be used. |
|
|
||
| image: ImageField = InputField(description="An input mask image with black and white content") | ||
| margin: int = InputField(default=0, ge=0, description="The desired margin around the object, as measured in pixels") | ||
| object_color: Literal["white", "black"] = InputField( |
There was a problem hiding this comment.
SAM can output multi-colored masks, right? Maybe we want this to be a ColorField instead, and update the mask extraction accordingly.
A future UI component could let the user click the specific mask they want, sampling its color, and then pass that into this node. So it'd be like a two-stage filter - segment, then choose the mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update to include a new node for Cropping to an identified object from automated masking nodes (e.g., Segment Anything), with the ability to configure for mask types and leverage resulting offsets later in the workflow.
Secondly, update Image Mask node to handle multiple formats for Image Masks. (May be unnecessary - check me)
Related Issues / Discussions
#6805
QA Instructions
Merge Plan
N/A
Checklist