Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy(ui): cleanup #5809

Merged
merged 25 commits into from
Feb 27, 2024
Merged

tidy(ui): cleanup #5809

merged 25 commits into from
Feb 27, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Feb 27, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Bug Fix
  • Cleanup

Description

  • Fix all typescript issues in frontend - future PRs much pass checks!
  • Add and use knip to remove OODLES of unused code
  • Add knip to frontend check workflow, it doesn't fail any but it does run the check
  • Move from madge to dpdm for circular dependencies, update workflow
  • Remove extraneous model install route - only the heuristic import is used now
  • Fix a number of issues in the new model manager UI - mostly related to types

QA Instructions, Screenshots, Recordings

App should still run. Thanks to all the static analysis tools we use, we can be confident nothing has broken

Merge Plan

This PR can be merged when approved

@github-actions github-actions bot added api python PRs that change python files backend PRs that change backend files services PRs that change app services frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files CICD labels Feb 27, 2024
@psychedelicious psychedelicious force-pushed the psyche/tidy/ui/cleanup branch 2 times, most recently from e40fda1 to 24a1aa6 Compare February 27, 2024 07:49
@psychedelicious
fix(ui): fix missing component import
27c7cea
@psychedelicious
feat(ui): add knip + minimal config
22f42cd 
https://knip.dev/

Replaces `unimported`
@psychedelicious
tidy(ui): clean up unused code 1
8d2c5d6 
- Only export when necessary
- Remove totally usused functions, variables, state, etc
- Remove unused packages
@psychedelicious
tidy(mm): remove ONNX from AnyModelConfig
e5b2858
@psychedelicious
tidy(api): remove non-heuristic install route
c60d49e
@psychedelicious
fix(ui): fix up MM queries & types (wip)
eb4fbb4
@psychedelicious
fix(ui): fix remaining TS issues
068d737
@psychedelicious
chore(ui): lint
47a9a0b
@psychedelicious
fix(ui): model install progress sets total bytes correctly
d6fdfad
@psychedelicious
feat(mm): add log stmt for download complete event
71b2dee
@psychedelicious
tidy(ui): clean up unused code 2
24bc0f7 
types and schemas
@psychedelicious
tidy(ui): clean up unused code 3
7cbeb94 
variables, types and schemas
@psychedelicious
tidy(ui): clean up unused code 4
5053c99 
variables, types and schemas
@psychedelicious
tidy(ui): clean up unused code 5
bf43c10 
variables, types and schemas
@psychedelicious
tidy(ui): clean up unused code 6
595636f 
unused files
@psychedelicious
feat(ui): configure knip
f3c59e6
@psychedelicious
ci: add knip to ui check workflow
785a4fc
@psychedelicious
chore(ui): update pnpm-lock.yaml
e509546 
Forgot to run `pnpm i` earlier after removing packages.
@psychedelicious
chore(ui): typegen, update knip config
ad619b5 
Knip should never touch the autogenerated types
@psychedelicious
tidy: remove some traces of ONNX
74cd39b
@psychedelicious
tidy(ui): fix circular dependencies in listeners
5a112ed
@psychedelicious
feat(ui): move from madge to dpdm for circular dependencies
db79071
@psychedelicious
ci: change frontend check to dpdm
5ea33e5
@psychedelicious
chore(ui): bump deps
7145eee 
The only major version is `query-string`. The breaking change for it is dropping support for old versions of node. Not a problem for us.
@psychedelicious
fix(ui): merge conflict
30c57c0
@hipsterusername hipsterusername merged commit 18af534 into next Feb 27, 2024
7 of 8 checks passed
@hipsterusername hipsterusername deleted the psyche/tidy/ui/cleanup branch February 27, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@GreggHelt2 GreggHelt2 Awaiting requested review from GreggHelt2

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

@ebr ebr Awaiting requested review from ebr ebr is a code owner

Assignees
No one assigned
Labels
api backend PRs that change backend files CICD frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername