Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(firestore): fix jest tests #8257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

russellwheatley
Copy link
Member

Description

This needs merging to fix this: https://github.com/invertase/react-native-firebase/actions/runs/13052719427/job/36416387337?pr=8236

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 1:20pm

Comment on lines +682 to +686
expect(indexManager!.constructor.name).toEqual('FirestorePersistentCacheIndexManager');

expect(indexManager.enableIndexAutoCreation).toBeInstanceOf(Function);
expect(indexManager.disableIndexAutoCreation).toBeInstanceOf(Function);
expect(indexManager.deleteAllIndexes).toBeInstanceOf(Function);
expect(indexManager!.enableIndexAutoCreation).toBeInstanceOf(Function);
expect(indexManager!.disableIndexAutoCreation).toBeInstanceOf(Function);
expect(indexManager!.deleteAllIndexes).toBeInstanceOf(Function);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it working with ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants